Textpattern CMS support forum

You are not logged in. Register | Login | Help

#11 2005-05-27 02:11:11

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

Yes, I’d agree it’s near the top of the list of Needed Features. As to the “far superior” bit, I think any experienced Txp & Wp user would agree that both have equal strengths and weaknesses. But that argument is a long one that no one is likely to win (and a pointless one, at that).

Offline

#12 2005-05-28 12:14:13

Anark
Member
Registered: 2004-08-14
Posts: 101

Re: Request : subscribe to comment plugin ?

Hey — I meant to pique the pride of a PHP-savvy TXP user rather than start an argument.

I don’t speak PHP myself — let me just try to understand the database tables issue. If a plugin like this requires an additional database table for storing e-mail addresses, you’ll need to ask the user to create that database table as a precondition of running the plugin. Surely that isn’t an unreasonable request?

Offline

#13 2005-05-28 15:09:20

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

Very true. I actually did just that for the admin notepad plugin (and previously the notepad hack).

Offline

#14 2005-08-11 20:41:04

MattH
Member
From: Ann Arbor, MI
Registered: 2004-10-17
Posts: 30

Re: Request : subscribe to comment plugin ?

Just to bump the thread: This is a feature that I’d really love to have. Any progress or hackish solution?

Offline

#15 2005-08-13 15:11:09

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

I have it on my to-do list for monday when I get back in town to at least try and assess the status of this – I’ll let you know.

Offline

#16 2005-08-13 16:25:29

alicson
Member
Registered: 2004-05-26
Posts: 465
Website

Re: Request : subscribe to comment plugin ?

> Andrew wrote:
> I have it on my to-do list for monday

for he’s a jolly good fellow, for he’s a jolly good fellow, for he’s a jolly good fe-el-low….. which nobody can deny!!


textpattern.org :: find and share Textpattern resources
docs.textpattern.io :: Textpattern user documentation

Offline

#17 2005-08-16 06:35:48

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

Ok, I’ve submitted a bare-bones beta patch (that likely will need quite a bit of major adjustments) in order to get per-post comments feeds in RSS. I’ll move on to Atom after I receive a response. The good news is that it looks like quite a reasonable modification, as long as I’m not ignoring something major.

As far as subscriptions go, (like MT’s emailing of comments and subscription management), I hope it doesn’t disappoint anyone that I won’t be touching that. I feel that feeds for comments are more than sufficient for keeping readers updated.

Offline

#18 2005-08-16 19:52:13

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

Ok, patch updated. I’m not recommending this to any inexperienced users, but if anyone feels like playing around a bit you can grab the patch and try it out. It was based off of v4.0 r807.

You may be asking why I did this approach instead of a plugin. Well, first off it’s not possible to modify rss.php’s and atom.php’s behavior from within a plugin. So that meant I really was looking at creating a standalone drop-n-go file, which would just complicate things. This patch is forward-friendly (if you’re svn-savvy) and can easily be brought into the core, once approved.

Affected files:

  • /textpattern/publish/rss.php
  • /textpattern/publish/atom.php
  • /textpattern/publish/taghandlers.php

It also adds a tag <txp:comments_feed_link />, which is similar in functionality to the other txp feed tags.

Acceptable URLs are as follows:

  • http://domain.tld/?rss=1&area=comments (all comments rss feed)
  • http://domain.tld/?atom=1&area=comments (all comments atom feed)
  • http://domain.tld/?rss=1&area=comments&id=1 (per-post rss feed for id 1)
  • http://domain.tld/?atom=1&area=comments&id=1 (per-post atom feed for id 1)
  • http://domain.tld/?rss=1&area=comments&limit=20 (all comments rss feed limit 20)
  • http://domain.tld/?atom=1&area=comments&limit=20 (all comments atom feed limit 20)

There may be bugs or changes, so maybe only install on a test site for now unless you know what you’re doing.

Future features that are outside of this scope:

  • Clean feeds (this goes hand-in-hand with also extending /rss & /atom to accept section, category, limit)
  • Per-category & per-section comment feeds? (sorta superfluous)

Last edited by Andrew (2005-11-09 05:53:13)

Offline

#19 2005-08-16 21:33:05

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

I’ve set up a download for those of you who may want to try it out (unzip to /textpattern/publish). It includes the three files that you’ll need to replace and is intended for use with Txp v4.0.

This isn’t for the faint of heart however, and I strongly recommend that you first backup and thoroughly compare your originals with the replacement files. A file-diffing utility such as Beyond Compare would help to easily see what changed between files.

Offline

#20 2005-08-16 21:42:58

Andrew
Plugin Author
Registered: 2004-02-23
Posts: 730

Re: Request : subscribe to comment plugin ?

And for those of you who can’t do without email subscriptions (I acknowledge that most inhabitants of the InterWebNets are still not feed-savvy), perhaps some combination of this with R-Mail?

Offline

Board footer

Powered by FluxBB