Textpattern CMS support forum

You are not logged in. Register | Login | Help

#21 2018-03-21 12:55:00

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: [TXP v4.7+] When a theme is stored in the database, will it lose data?

The regex was inherited from Gocom’s rah_flat. Could we just remove it (or make it consistent with the DB related naming conventions)? If a file fail to be written, it should display a warning anyway. Then, nothing more we can do I guess.

Last edited by NicolasGraph (2018-03-21 12:55:30)


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

#22 2018-03-21 14:15:27

etc
Developer
Registered: 2010-11-11
Posts: 2,950
Website

Re: [TXP v4.7+] When a theme is stored in the database, will it lose data?

NicolasGraph wrote #310196:

The regex was inherited from Gocom’s rah_flat. Could we just remove it (or make it consistent with the DB related naming conventions)? If a file fail to be written, it should display a warning anyway. Then, nothing more we can do I guess.

No, I’m afraid, a file could be written to a wrong directory if the name contains / or . or something else as weird. I feel that this sync options should be off by default and not memorized, until we find a solution.


etc_[ query | search | pagination | date | tree | cache ]

Offline

#23 2018-03-21 14:20:23

NicolasGraph
Plugin Author
From: France
Registered: 2008-07-24
Posts: 860
Website

Re: [TXP v4.7+] When a theme is stored in the database, will it lose data?

etc wrote #310202:

No, I’m afraid, a file could be written to a wrong directory if the name contains / or . or something else as weird.

/ is not allowed in names but . is, you’re right.

I feel that this sync options should be off by default and not memorized, until we find a solution.

It seems reasonable.

Last edited by NicolasGraph (2018-03-21 14:21:34)


Nicolas
Follow me on Twitter and GitHub!
Multiple edits are usually to correct my frenglish…

Offline

Board footer

Powered by FluxBB