Textpattern CMS support forum

You are not logged in. Register | Login | Help

#111 2016-08-30 14:18:40

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,092
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

I’ll do it at some point today, I’m sure there is a way to keep the intended markup.

Offline

#112 2016-08-30 14:21:53

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,546
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Bloke wrote #300876:

Yeah, that’s easy. Phil might have to alter the markup and/or CSS to make it continue to exhibit the same inline-block / floaty behaviour…

I don’t think any changes are needed to the CSS, unless I’ve missed something, the <a> will just float its way like it does now.

Mind I still prefer the intended markup – the narrative is just more logical

Offline

#113 2016-08-30 14:22:30

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,458
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

philwareham wrote #300877:

I’ll do it at some point today, I’m sure there is a way to keep the intended markup.

Cool, thanks. There is a way, it’s just a bit convoluted unless we can find some way to hack inputLabel() in a suitable fashion.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#114 2016-08-30 14:23:30

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,092
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Bloke wrote #300880:

Cool, thanks. There is a way, it’s just a bit convoluted unless we can find some way to hack inputLabel() in a suitable fashion.

Hmmm, OK, I’m open to suggestions there.

Offline

#115 2016-08-31 10:46:12

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,458
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

phiw13: we went with the (unlisted in my post above) option #5 to fix the tag builder link position: hack inputLabel(). Please try the latest master branch.

Also made the dialog focus default to the close button on initialisation instead of the first link. The Build button might also be a candidate, though it’s not always present so it was simpler to hook into an omni-present widget.


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#116 2016-08-31 10:49:22

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,092
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Bloke wrote #300895:

Also made the dialog focus default to the close button on initialisation instead of the first link. The Build button might also be a candidate, though it’s not always present so it was simpler to hook into an omni-present widget.

Cheers Stef. I think the close button is the correct tab focus point for dialogs (it’s at the start of the content flow).

Offline

#117 2016-08-31 12:38:01

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,546
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

Bloke wrote #300895:

phiw13: we went with the (unlisted in my post above) option #5 to fix the tag builder link position: hack inputLabel(). Please try the latest master branch.

Lovely. TY.

Note: your last patch lacks a space between the icon span and the text string – I noted that on github. Fixed already!

Also made the dialog focus default to the close button on initialisation instead of the first link. The Build button might also be a candidate, though it’s not always present so it was simpler to hook into an omni-present widget.

Hmm. Not 100% enthusiast with that; on the flip side, given that those tag builder dialogs lacks a “cancel” button, perhaps it is OK. But then again, esc also closes the dialog, wherever the focus is.

Now I notice (but that is not new): you launch the tag builder, you can interact with it from the keyboard. Select something to build a tag (e.g. “Category 1”). The actual tab builder form opens, but the focus is nowhere in the dialog, it returns to the first focusable element of the page (the Texpattern logo).

Last edited by phiw13 (2016-08-31 12:41:58)

Offline

#118 2016-08-31 12:45:05

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,092
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

phiw13 wrote #300899:

Now I notice (but that is not new): you launch the tag builder, you can interact with it from the keyboard. Select something to build a tag (e.g. “Category 1”). The actual tab builder form opens, but the focus is nowhere in the dialog, it returns to the first focusable element of the page (the Texpattern logo).

Can you please create that as an issue on GitHub?

Offline

#119 2016-08-31 12:58:42

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,546
Website

Re: Feedback to: Textpattern CMS 4.6.0 beta 2 released

philwareham wrote #300900:

Can you please create that as an issue on GitHub?

Sure: issue 751 filed.

Offline

Board footer

Powered by FluxBB