Textpattern CMS support forum

You are not logged in. Register | Login | Help

#1 2013-08-18 07:25:03

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,093
Website

Call to help translate (now via GitHub)

We are planning to change the way Textpattern handles languages. The first part of this work is moving language translations off the RPC server, and making them publicly available/editable on GitHub.

We invite you to fork and fill in any blanks in current language files. Of course you are welcome to add extra languages if a desired language file currently does not exist – that would be great.

Further instructions can be found at the GitHub repo

The Textpattern inline help files will also move to GitHub in due course, hopefully.

Offline

#2 2013-08-18 20:05:50

kees-b
Member
From: middelburg, nl
Registered: 2004-03-03
Posts: 234
Website

Re: Call to help translate (now via GitHub)

Hi Phil,

Can you explain how the current translators fit into this new setup? Do we need to sign up for a github account first? Does this also mean translations are editable by anybody?

Kees (nl-nl)

Offline

#3 2013-08-18 22:53:37

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,093
Website

Re: Call to help translate (now via GitHub)

Yes you’ll need a GitHub account and then you’d need to fork the repository. Make changes in your own fork and then pull request back to the master repository.

We then review the pull request and if all looks ok we merge changes into master.

Sounds convoluted but it’s actually pretty simple, especially if you use GitHub’s MacOSX or Windows apps.

Offline

#4 2013-08-19 01:12:25

Gocom
Plugin Author
Registered: 2006-07-14
Posts: 4,524
Website

Re: Call to help translate (now via GitHub)

kees-b wrote:

Does this also mean translations are editable by anybody?

Contributions are accepted from anybody. As Phil states, contributions are merged to the repository after reviewing on pull request basis. The repository is authored by core developers.

philwareham wrote:

especially if you use GitHub’s MacOSX or Windows apps

Does it truly work? They completely expose branching, fetching, merging and rebasing? And the interface ends up making sense? If not, you can’t truly use the app for forking. Unless you happen to contribute to a repository that is in a frozen state.

If I wanted to make alterations to a translation, the workflow would look something like:

$ git clone git@github.com:gocom/textpacks.git
$ cd textpacks
$ git remote add upstream https://github.com/textpattern/textpacks.git
$ git fetch upstream
$ git checkout -b feature-en-GB-proper-nouns
$ git rebase upstream/master
$ mate textpacks/en-gb.textpack
$ git add textpacks/en-gb.text
$ git commit -m "Corrections to proper noun casing."
$ git rebase upstream/master
$ git push origin feature-en-GB-proper-nouns

Which translates to:

  1. Clone my fork I created on GitHub.
  2. Move to the project directory created by cloning.
  3. Adds remote to the upstream repository so that I can update my clone from it.
  4. Fetches changes from upstream without modifying my files.
  5. Creates a new feature branch and changes to it.
  6. Rebases upstream changes to my local branch.
  7. Opens the en-gb.textpack in Textmate. I now would do my edits to it and save.
  8. Stages the en-gb.textpack
  9. Commits the changes.
  10. Makes sure the history is up to date. Basically moves my “Corrections to proper noun casing.” to the top.
  11. Pushes the local branch to my GitHub clone.

Now I would go to GitHub and send in a pull request. Go to my clone’s GitHub page, press the pull request button. Pick my feature-en-GB-proper-nouns branch and master as the upstream target. Write in explanation about what I’ve done and why, and press the green send pull request button.

Last edited by Gocom (2013-08-19 01:13:48)

Offline

#5 2013-08-19 04:25:20

wet
Developer
From: Lenzing, Austria
Registered: 2005-06-06
Posts: 3,267
Website

Re: Call to help translate (now via GitHub)

Gocom wrote:

If I wanted to make alterations to a translation, the workflow would look something like:

I think you’d need to provide this workflow as a verbose and probably illustrated step-by-step instruction to help the current translators make the transition from the current simple, easily navigable web form on the RPC server to this complex tool invocation.

Offline

#6 2013-08-19 07:09:21

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,093
Website

Re: Call to help translate (now via GitHub)

I’ll knock up a flowchart diagram this evening. People could also simply raise an issue and then paste in any missing strings into the issue message for very quick edits.

Offline

#7 2013-08-19 11:27:00

kees-b
Member
From: middelburg, nl
Registered: 2004-03-03
Posts: 234
Website

Re: Call to help translate (now via GitHub)

wet wrote:


I think you’d need to provide this workflow as a verbose and probably illustrated step-by-step instruction to help the current translators make the transition from the current simple, easily navigable web form on the RPC server to this complex tool invocation.

Good idea!

But I also would like to discuss the underlying concept of managing localizations as if they are the same as code. They are not! I have been maintaining the nl localization since 2004 with occasional help from Els and other forum members. In my view a localization should be consistent in style, syntax and all other language aspects. Making decisions in a translation is not necessarily a democratic process. This means that in my opinion at least one native speaker per language should be core reviewer before final merging by the txp developers.

Is this new github setup not making the localization process much more complex?

Kees

Offline

#8 2013-08-19 11:36:18

philwareham
Core designer
From: Farnham, Surrey, UK
Registered: 2009-06-11
Posts: 3,093
Website

Re: Call to help translate (now via GitHub)

kees-b wrote:

Is this new github setup not making the localization process much more complex?

It’s about making the localization process work well, which it doesn’t at the moment by burying everything within a closed server (with no checks in place that things are done correctly). The system needs to be version controlled too so the correct language pack versions are available for the correct Textpattern version – GitHub can achieve that.

I agree however that there should still be an overall peer reviewer/moderator for each language. We’ll probably need to compile a list of peer reviewers – which should also be within the GitHub repo or somewhere easily accessible. I currently have no idea how many of the previous translators are still active within the community.

Offline

#9 2013-08-19 11:49:40

wet
Developer
From: Lenzing, Austria
Registered: 2005-06-06
Posts: 3,267
Website

Re: Call to help translate (now via GitHub)

philwareham wrote:

I currently have no idea how many of the previous translators are still active within the community.

A hint:

mysql> select name, translate, last_access from txp_users where last_access > date_sub(now(), interval 1 year) order by last_access desc;
+-------------+----------------------------+---------------------+
| name        | translate                  | last_access         |
+-------------+----------------------------+---------------------+
| wet         | de-de                      | 2013-08-19 11:42:58 |
| Pat64       | fr-fr                      | 2013-08-18 07:47:08 |
| philwareham | en-gb,en-us                | 2013-08-16 08:45:45 |
| milosberka  | cs-cz                      | 2013-08-06 06:24:01 |
| kees-b      | nl-nl                      | 2013-08-05 16:08:37 |
| pompilos    | es-es                      | 2013-07-09 16:39:30 |
| lll9p       | zh-cn                      | 2013-06-14 00:46:58 |
| nn--        | ja-jp                      | 2013-06-06 13:56:32 |
| beztak      | cs-cz                      | 2013-04-22 08:20:41 |
| gour        | hr-hr                      | 2013-03-16 08:34:19 |
| cbasilio    | pt-pt, pt-br               | 2013-03-09 10:43:17 |
| giampablo   | it-it                      | 2013-01-23 20:06:36 |
| papuass     | lv-lv                      | 2012-12-13 14:28:15 |
| els         | nl-nl                      | 2012-10-23 23:27:56 |
| makss       | ru-ru,uk-ua                | 2012-10-15 10:59:26 |
| sinacher    | fa-ir                      | 2012-09-15 10:03:20 |
| the_ghost   | ru-ru                      | 2012-09-10 21:07:57 |
| eg          | lt-lt                      | 2012-08-24 08:48:14 |
+-------------+----------------------------+---------------------+
19 rows in set (0.00 sec)

Offline

#10 2013-08-19 11:50:07

kees-b
Member
From: middelburg, nl
Registered: 2004-03-03
Posts: 234
Website

Re: Call to help translate (now via GitHub)

philwareham wrote:

I agree however that there should still be an overall peer reviewer/moderator for each language. We’ll probably need to compile a list of peer reviewers – which should also be within the GitHub repo or somewhere easily accessible.

Hi Phil,

I have set up a github account (keesbran) and will gladly volunteer as nl-nl peer reviewer.

I currently have no idea how many of the previous translators are still active within the community.

Can’t you check last logins on the RPC server?

-k

Last edited by kees-b (2013-08-19 11:55:57)

Offline

Board footer

Powered by FluxBB