Textpattern CMS support forum

You are not logged in. Register | Login | Help

#91 2012-08-09 08:21:35

wet
Developer
From: Lenzing, Austria
Registered: 2005-06-06
Posts: 3,267
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

tye wrote:

Are there reasons you have to click the x to close the alerts/announcements? Is it possible to just click anywhere on the screen to close them?

Some might want to copy the message text by selecting with the mouse, for instance.

Offline

#92 2012-08-09 08:43:45

Gocom
Plugin Author
Registered: 2006-07-14
Posts: 4,524
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

Damn that was fast. The multi-edit script probably should use .on() too. But, hmm, it may need some refactoring if it’s changed. I believe the use of triggering will lead to recursion if one just replaces the live with .on().

Offline

#93 2012-08-09 08:44:56

phiw13
Plugin Author
From: Japan
Registered: 2004-02-27
Posts: 1,593
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

wet wrote:

Thanks. Please try r4056.

Yep, works fine now.

Gocom wrote:

Thanks for analyzing.

Offline

#94 2012-08-09 15:50:32

maniqui
Moderator
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

wet wrote:

A plugin issue. We expect a few inevitable incompatibilities with plugins for the write tab due to the new plugin types and AJAX adaptations.

With msd_minibar, the “Sorry the form could not be submitted. Please try again later.” alert message appears each time I try to save the article. It seems that the article gets saved anyway (although I’m not ye 100% sure it gets saved every time I click it).


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#95 2012-08-09 17:22:50

maniqui
Moderator
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

I can confirm that the plugin works fine when installed in the DB, but triggers the above alert message when running from plugin cache dir.

According to plugin author, “there aren’t any lifecycle events that take place on install for this plugin or anything complicated going on.”

I will try to find anything else related to this issue.


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#96 2012-08-10 02:27:25

Gocom
Plugin Author
Registered: 2006-07-14
Posts: 4,524
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

maniqui wrote:

With msd_minibar, the “Sorry the form could not be submitted. Please try again later.” alert message appears each time I try to save the article. It seems that the article gets saved anyway (although I’m not ye 100% sure it gets saved every time I click it).

The article would be saved on each time, it’s just the script response that is invalid, so don’t worry about that. These issues are due to the plugin cache directory you are using. Any PHP file that is placed to the plugin cache directory is loaded globally, on each interface-side, on each type of response. This will evidently cause issues as the plugins will be loaded on places where they shouldn’t be.

I will try to find anything else related to this issue.

Here-here.

Last edited by Gocom (2012-08-10 02:27:51)

Offline

#97 2012-08-10 02:51:22

maniqui
Moderator
From: Buenos Aires, Argentina
Registered: 2004-10-10
Posts: 3,070
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

Any PHP file that is placed to the plugin cache directory is loaded globally, on each interface-side, on each type of response. This will evidently cause issues as the plugins will be loaded on places where they shouldn’t be.

Oh, that doesn’t sound encouraging :(
Being the convenience (imo) of installing/using the plugins directly from the plugin cache dir, I hope there could be some developments to make plugins running from cache dir to work exactly like those running from DB.
In any case, having some of them running from DB and others from cache dir won’t be a big deal, really, and I can live with that.

Thanks, Gogom.


La música ideas portará y siempre continuará

TXP Builders – finely-crafted code, design and txp

Offline

#98 2012-08-21 04:16:14

Rimfya
Member
Registered: 2007-11-22
Posts: 31

Re: Feedback to: Textpattern 4.5.0 Beta released

Is there any timeframe for the stable release?

Offline

#99 2012-08-21 10:19:03

Bloke
Developer
From: Leeds, UK
Registered: 2006-01-29
Posts: 8,572
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

maniqui wrote:

I hope there could be some developments to make plugins running from cache dir to work exactly like those running from DB.

That would probably involve either:

  • Reading the files as they are loaded, detecting the Type in the template (if indeed the files are in template format: they don’t have to be, which is why the cache dir is not recommended for production environments).
  • Permitting the filenames to indicate the plugin’s type (e.g. ied_plugin_composer_v1.00_TYPE4.php).
  • Introducing some kind of directory structure convention so the files can be organised by type, or function, or whatever.

The first two are cumbersome or slow. The last one might have merit and is (sort of) the way things can be organised now, albeit in a binary fashion, i.e. put all files you want to load in the cache dir and put any files you don’t want to load in some other subdirectory. As you well know, that gives the flexibility to switch plugins on and off by just moving them between directories, which is also very versioning friendly. This would just be an extension whereby some predefined directory names could trigger certain behaviour — a bit like the old ‘S’ and ‘K’ runlevel files in UNIX’s rc.d system. Maybe the directories are just the plugin types: drop all admin-and-ajax plugins in the 4 directory, for example. Things like library plugins would fall foul of the system so they’d need special dispensation, and it would have to be backwards compatible somehow.

Even if we do something like that one day, it won’t necessarily stop plugins from running on inapprpriate hook points because — as Gocom mentioned — they can attach at any point and could, therefore, get executed at an unexpected time. It may, however, offer some level of protection for plugin types 3/4/5 against sending non-AJAX responses to an AJAX request. Providing of course you put the plugins in the right subdirectory :-)

This whole cache dir thing could probably be improved overall though. We could toss around ideas on a separate thread if you like (in fact I’m sure there was a thread started ages ago about this…)


The smd plugin menagerie — for when you need one more gribble of power from Textpattern. Bleeding-edge code available on GitHub.

Txp Builders – finely-crafted code, design and Txp

Offline

#100 2012-08-21 10:24:08

jpdupont
Member
From: Virton (BE)
Registered: 2004-10-01
Posts: 752
Website

Re: Feedback to: Textpattern 4.5.0 Beta released

I’ trying smd_macro on the new 4.5 beta.

My macro works on many 4.4.1 sites.

  1. On 4.5, I get a first error in the <txp:images tag I use in the macro : I must set a sort order to avoid the error.
  2. Then I get an other error on the <txp:smd_thumnail tag : “Textpattern Warning: tag does not exist while parsing form “None” on page “demo”

Here I don’t understand : smd_tumbnail is active, type expected is created (carre_100)

My test site is here : test45.alysse.com/demo

My macro (may be downloaded on the site above) :

<txp:variable name="image_ids">{img_id},<txp:images category="{img_cat}" break=","><txp:image_info type="id" /></txp:images></txp:variable>

<txp:variable name="counter" value="0" />
<txp:variable name="maxaff" value="{max_thumb_display}" />

<txp:images sort="id asc" break="" wraptag="" class="galerie" id='<txp:variable name="image_ids" />'>
   <a href="<txp:image_url />" class="{cls_fbox}" rel="{img_rel}">
      <txp:adi_calc name="counter" add="1"  />
<txp:smd_if field="txpvar:counter"
     operator="gt"
     value="txpvar:maxaff" >
      <txp:smd_thumbnail type="{thumb_type}" class="{cls_thumb_cache}" />
<txp:else />
      <txp:smd_thumbnail type="{thumb_type}" class="{cls_thumb}" />
</txp:smd_if>
   </a>
</txp:images>

Offline

Board footer

Powered by FluxBB